diff options
author | Stephen Boyd <[email protected]> | 2019-07-30 11:15:53 -0700 |
---|---|---|
committer | Andy Shevchenko <[email protected]> | 2019-08-01 18:03:02 +0300 |
commit | eaae882c4a77c8aa2ca20d4447aeb81d9d5eec97 (patch) | |
tree | e8121217f8ac24d7dadb4421559a51c195f0c0e0 | |
parent | 50944213062f7605ef79604418c7e3468d97b109 (diff) |
platform/mellanox: mlxreg-hotplug: Remove dev_err() usage after platform_get_irq()
We don't need dev_err() messages when platform_get_irq() fails now that
platform_get_irq() prints an error message itself when something goes
wrong. Let's remove these prints with a simple semantic patch.
// <smpl>
@@
expression ret;
struct platform_device *E;
@@
ret =
(
platform_get_irq(E, ...)
|
platform_get_irq_byname(E, ...)
);
if ( \( ret < 0 \| ret <= 0 \) )
{
(
-if (ret != -EPROBE_DEFER)
-{ ...
-dev_err(...);
-... }
|
...
-dev_err(...);
)
...
}
// </smpl>
While we're here, remove braces on if statements that only have one
statement (manually).
Cc: Andy Shevchenko <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Enric Balletbo i Serra <[email protected]>
Cc: Hans de Goede <[email protected]>
Cc: "Darren Hart (VMware)" <[email protected]>
Cc: Roman Kiryanov <[email protected]>
Cc: Vadim Pasternak <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Stephen Boyd <[email protected]>
Signed-off-by: Andy Shevchenko <[email protected]>
-rw-r--r-- | drivers/platform/mellanox/mlxreg-hotplug.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/platform/mellanox/mlxreg-hotplug.c b/drivers/platform/mellanox/mlxreg-hotplug.c index f85a1b9d129b..706207d192ae 100644 --- a/drivers/platform/mellanox/mlxreg-hotplug.c +++ b/drivers/platform/mellanox/mlxreg-hotplug.c @@ -642,11 +642,8 @@ static int mlxreg_hotplug_probe(struct platform_device *pdev) priv->irq = pdata->irq; } else { priv->irq = platform_get_irq(pdev, 0); - if (priv->irq < 0) { - dev_err(&pdev->dev, "Failed to get platform irq: %d\n", - priv->irq); + if (priv->irq < 0) return priv->irq; - } } priv->regmap = pdata->regmap; |