aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorXiangliang Yu <[email protected]>2016-11-30 14:07:16 +0800
committerAlex Deucher <[email protected]>2016-12-06 18:08:38 -0500
commite9efaaa047b1aebda27b5b65f17c752eb079e51b (patch)
tree764bfdd14e3eb5c12d63edda3e4688a218f77868
parent84f3f05b44327b7517086ae048f4131ec175e7b5 (diff)
drm/amd/powerplay: Fix potential NULL pointer issue
If doesn't enable dpm, the powerplay will not allocate memory for hw management. So, hw_init_power_state_table function will reference NULL pointer when resetting. Signed-off-by: Xiangliang Yu <[email protected]> Reviewed-by: Rex Zhu <[email protected]> Reviewed-by: Alex Deucher <[email protected]> Acked-by: Christian König <[email protected]> Signed-off-by: Alex Deucher <[email protected]> Cc: [email protected]
-rw-r--r--drivers/gpu/drm/amd/powerplay/amd_powerplay.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
index 51a36077b993..c81cf1412728 100644
--- a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
+++ b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
@@ -1004,12 +1004,12 @@ int amd_powerplay_reset(void *handle)
if (ret)
return ret;
- hw_init_power_state_table(instance->hwmgr);
-
if ((amdgpu_dpm == 0)
|| cgs_is_virtualization_enabled(instance->smu_mgr->device))
return 0;
+ hw_init_power_state_table(instance->hwmgr);
+
if (eventmgr == NULL || eventmgr->pp_eventmgr_init == NULL)
return -EINVAL;