aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBoris Ostrovsky <[email protected]>2011-05-26 11:19:52 -0400
committerH. Peter Anvin <[email protected]>2011-05-26 10:38:30 -0700
commite9cdd343a5e42c43bcda01e609fa23089e026470 (patch)
treecc814236d5dfc6c8555c3c630a493a85d23fbd93
parentb80ef10e84d85a06bcd0b3a24a752ec32d0e0e40 (diff)
x86, amd: Do not enable ARAT feature on AMD processors below family 0x12
Commit b87cf80af3ba4b4c008b4face3c68d604e1715c6 added support for ARAT (Always Running APIC timer) on AMD processors that are not affected by erratum 400. This erratum is present on certain processor families and prevents APIC timer from waking up the CPU when it is in a deep C state, including C1E state. Determining whether a processor is affected by this erratum may have some corner cases and handling these cases is somewhat complicated. In the interest of simplicity we won't claim ARAT support on processor families below 0x12 and will go back to broadcasting timer when going idle. Signed-off-by: Boris Ostrovsky <[email protected]> Link: http://lkml.kernel.org/r/[email protected] Tested-by: Boris Petkov <[email protected]> Cc: Hans Rosenfeld <[email protected]> Cc: Andreas Herrmann <[email protected]> Cc: Chuck Ebbert <[email protected]> Cc: [email protected] # 32.x, 38.x, 39.x Signed-off-by: H. Peter Anvin <[email protected]>
-rw-r--r--arch/x86/kernel/cpu/amd.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
index 8f5cabb3c5b0..b13ed393dfce 100644
--- a/arch/x86/kernel/cpu/amd.c
+++ b/arch/x86/kernel/cpu/amd.c
@@ -612,8 +612,11 @@ static void __cpuinit init_amd(struct cpuinfo_x86 *c)
}
#endif
- /* As a rule processors have APIC timer running in deep C states */
- if (c->x86 > 0xf && !cpu_has_amd_erratum(amd_erratum_400))
+ /*
+ * Family 0x12 and above processors have APIC timer
+ * running in deep C states.
+ */
+ if (c->x86 > 0x11)
set_cpu_cap(c, X86_FEATURE_ARAT);
/*