diff options
| author | Chengfeng Ye <[email protected]> | 2021-11-04 06:46:42 -0700 |
|---|---|---|
| committer | Herbert Xu <[email protected]> | 2021-11-20 15:02:08 +1100 |
| commit | e9c195aaeed1b45c9012adbe29dedb6031e85aa8 (patch) | |
| tree | f3c77d9cd5a2e7069f1e50ec7d6f4103cdc985dc | |
| parent | b4cb4d31631912842eb7dce02b4350cbb7562d5e (diff) | |
crypto: qce - fix uaf on qce_skcipher_register_one
Pointer alg points to sub field of tmpl, it
is dereferenced after tmpl is freed. Fix
this by accessing alg before free tmpl.
Fixes: ec8f5d8f ("crypto: qce - Qualcomm crypto engine driver")
Signed-off-by: Chengfeng Ye <[email protected]>
Acked-by: Thara Gopinath <[email protected]>
Signed-off-by: Herbert Xu <[email protected]>
| -rw-r--r-- | drivers/crypto/qce/skcipher.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/crypto/qce/skcipher.c b/drivers/crypto/qce/skcipher.c index 8ff10928f581..3d27cd5210ef 100644 --- a/drivers/crypto/qce/skcipher.c +++ b/drivers/crypto/qce/skcipher.c @@ -484,8 +484,8 @@ static int qce_skcipher_register_one(const struct qce_skcipher_def *def, ret = crypto_register_skcipher(alg); if (ret) { - kfree(tmpl); dev_err(qce->dev, "%s registration failed\n", alg->base.cra_name); + kfree(tmpl); return ret; } |