aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSlawomir Laba <[email protected]>2022-02-23 13:38:31 +0100
committerTony Nguyen <[email protected]>2022-02-25 11:37:07 -0800
commite85ff9c631e1bf109ce8428848dfc8e8b0041f48 (patch)
tree681cb729f2c39247c47b8e3c1e47e7ca1a1bd2a7
parenta472eb5cbaebb5774672c565e024336c039e9128 (diff)
iavf: Fix deadlock in iavf_reset_task
There exists a missing mutex_unlock call on crit_lock in iavf_reset_task call path. Unlock the crit_lock before returning from reset task. Fixes: 5ac49f3c2702 ("iavf: use mutexes for locking of critical sections") Signed-off-by: Slawomir Laba <[email protected]> Signed-off-by: Phani Burra <[email protected]> Signed-off-by: Jacob Keller <[email protected]> Signed-off-by: Mateusz Palczewski <[email protected]> Tested-by: Konrad Jankowski <[email protected]> Signed-off-by: Tony Nguyen <[email protected]>
-rw-r--r--drivers/net/ethernet/intel/iavf/iavf_main.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
index 36433d6504b7..da50ea3e44c2 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_main.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
@@ -2688,6 +2688,7 @@ static void iavf_reset_task(struct work_struct *work)
reg_val);
iavf_disable_vf(adapter);
mutex_unlock(&adapter->client_lock);
+ mutex_unlock(&adapter->crit_lock);
return; /* Do not attempt to reinit. It's dead, Jim. */
}