aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYang Yingliang <[email protected]>2022-07-13 10:56:55 +0800
committerMark Brown <[email protected]>2022-07-13 13:48:58 +0100
commite82c6d62a1f2347cde69c169fcf37e4d26f89b98 (patch)
tree01c4ee65fc2ada5e1a185bd1a0bc676259b73c1d
parentcdb0cc9379f1b4fa5ea3e0492bacf8008f3f4e5a (diff)
spi: microchip-core: fix UAF in mchp_corespi_remove()
When using devm_spi_register_master(), the unregister function will be called in devres_release_all() which is called after ->remove(), so remove spi_unregister_master() andspi_master_put(). Fixes: 9ac8d17694b6 ("spi: add support for microchip fpga spi controllers") Signed-off-by: Yang Yingliang <[email protected]> Reviewed-by: Conor Dooley <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
-rw-r--r--drivers/spi/spi-microchip-core.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/spi/spi-microchip-core.c b/drivers/spi/spi-microchip-core.c
index b3083075cd36..c26767343176 100644
--- a/drivers/spi/spi-microchip-core.c
+++ b/drivers/spi/spi-microchip-core.c
@@ -595,8 +595,6 @@ static int mchp_corespi_remove(struct platform_device *pdev)
struct mchp_corespi *spi = spi_master_get_devdata(master);
mchp_corespi_disable_ints(spi);
- spi_unregister_master(master);
- spi_master_put(master);
clk_disable_unprepare(spi->clk);
mchp_corespi_disable(spi);