diff options
| author | Ian Rogers <[email protected]> | 2021-11-07 01:54:44 -0700 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <[email protected]> | 2021-11-07 12:44:53 -0300 |
| commit | e4e290791d87b95b2b1fa991e504fba89cbe2a03 (patch) | |
| tree | bc776ad604f8cd3c5cf14cec89425d0429c5fb26 | |
| parent | 4e88118c20fc5fa7890230da2d26f0235dd904f5 (diff) | |
perf stat: Fix memory leak on error path
strdup() is used to deduplicate, ensure it isn't leaking an already
created string by freeing first.
Signed-off-by: Ian Rogers <[email protected]>
Cc: Alexander Shishkin <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: John Garry <[email protected]>
Cc: Mark Rutland <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Stephane Eranian <[email protected]>
Link: http://lore.kernel.org/lkml/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
| -rw-r--r-- | tools/perf/util/stat-shadow.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c index 69f3cf3b4a44..e4fb02b05130 100644 --- a/tools/perf/util/stat-shadow.c +++ b/tools/perf/util/stat-shadow.c @@ -444,6 +444,7 @@ void perf_stat__collect_metric_expr(struct evlist *evsel_list) "Add %s event to groups to get metric expression for %s\n", metric_name, counter->name); + free(printed); printed = strdup(metric_name); } invalid = true; |