aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMagnus Karlsson <[email protected]>2021-09-07 09:19:21 +0200
committerDaniel Borkmann <[email protected]>2021-09-10 21:15:31 +0200
commite2d850d5346c3cd751b032a7dccdd472013b8a84 (patch)
tree4a45f0190cf4da7ec657ea2592599b2eff9aa2e8
parentaf6731d1e1c69b4ee32063acd51ec86ece0a1ced (diff)
selftests: xsx: Make pthreads local scope
Make the pthread_t variables local scope instead of global. No reason for them to be global. Signed-off-by: Magnus Karlsson <[email protected]> Signed-off-by: Daniel Borkmann <[email protected]> Acked-by: Maciej Fijalkowski <[email protected]> Link: https://lore.kernel.org/bpf/[email protected]
-rw-r--r--tools/testing/selftests/bpf/xdpxceiver.c1
-rw-r--r--tools/testing/selftests/bpf/xdpxceiver.h2
2 files changed, 1 insertions, 2 deletions
diff --git a/tools/testing/selftests/bpf/xdpxceiver.c b/tools/testing/selftests/bpf/xdpxceiver.c
index 3a1afece7c2c..5ea78c503741 100644
--- a/tools/testing/selftests/bpf/xdpxceiver.c
+++ b/tools/testing/selftests/bpf/xdpxceiver.c
@@ -887,6 +887,7 @@ static void testapp_validate_traffic(struct test_spec *test)
struct ifobject *ifobj_tx = test->ifobj_tx;
struct ifobject *ifobj_rx = test->ifobj_rx;
struct pkt_stream *pkt_stream;
+ pthread_t t0, t1;
if (pthread_barrier_init(&barr, NULL, 2))
exit_with_error(errno);
diff --git a/tools/testing/selftests/bpf/xdpxceiver.h b/tools/testing/selftests/bpf/xdpxceiver.h
index 7ed16128f2ad..34ae4e4ea4ac 100644
--- a/tools/testing/selftests/bpf/xdpxceiver.h
+++ b/tools/testing/selftests/bpf/xdpxceiver.h
@@ -138,8 +138,6 @@ struct test_spec {
char name[MAX_TEST_NAME_SIZE];
};
-/*threads*/
pthread_barrier_t barr;
-pthread_t t0, t1;
#endif /* XDPXCEIVER_H */