diff options
| author | Ming Lei <[email protected]> | 2022-09-23 19:51:19 +0800 |
|---|---|---|
| committer | Tejun Heo <[email protected]> | 2022-09-23 07:18:45 -1000 |
| commit | df02452f3df069a59bc9e69c84435bf115cb6e37 (patch) | |
| tree | 4bbb542c16070918d40eb5746603739a45dce1d8 | |
| parent | a81e18e963ce13ecfa4f0f11b185bc8372f203f8 (diff) | |
cgroup: cgroup_get_from_id() must check the looked-up kn is a directory
cgroup has to be one kernfs dir, otherwise kernel panic is caused,
especially cgroup id is provide from userspace.
Reported-by: Marco Patalano <[email protected]>
Fixes: 6b658c4863c1 ("scsi: cgroup: Add cgroup_get_from_id()")
Cc: Muneendra <[email protected]>
Signed-off-by: Ming Lei <[email protected]>
Acked-by: Mukesh Ojha <[email protected]>
Cc: [email protected] # v5.14+
Signed-off-by: Tejun Heo <[email protected]>
| -rw-r--r-- | kernel/cgroup/cgroup.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index e4bb5d57f4d1..5f2090d051ac 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -6049,6 +6049,9 @@ struct cgroup *cgroup_get_from_id(u64 id) if (!kn) goto out; + if (kernfs_type(kn) != KERNFS_DIR) + goto put; + rcu_read_lock(); cgrp = rcu_dereference(*(void __rcu __force **)&kn->priv); @@ -6056,7 +6059,7 @@ struct cgroup *cgroup_get_from_id(u64 id) cgrp = NULL; rcu_read_unlock(); - +put: kernfs_put(kn); out: return cgrp; |