diff options
| author | Peter Ujfalusi <[email protected]> | 2023-04-03 12:09:09 +0300 |
|---|---|---|
| committer | Mark Brown <[email protected]> | 2023-04-03 12:13:44 +0100 |
| commit | de6aa72b265b72bca2b1897d5000c8f0147d3157 (patch) | |
| tree | 34ce1d4c267f01b4a039e79524e581d7f9563025 | |
| parent | e3720f92e0237921da537e47a0b24e27899203f8 (diff) | |
ASoC: SOF: ipc4-topology: Clarify bind failure caused by missing fw_module
The original patch uses a feature in lib/vsprintf.c to handle the invalid
address when tring to print *_fw_module->man4_module_entry.name when the
*rc_fw_module is NULL.
This case is handled by check_pointer_msg() internally and turns the
invalid pointer to '(efault)' for printing but it is hiding useful
information about the circumstances. Change the print to emmit the name
of the widget and a note on which side's fw_module is missing.
Fixes: e3720f92e023 ("ASoC: SOF: avoid a NULL dereference with unsupported widgets")
Reported-by: Dan Carpenter <[email protected]>
Link: https://lore.kernel.org/alsa-devel/[email protected]/
Signed-off-by: Peter Ujfalusi <[email protected]>
Rule: 'Cc: [email protected]' or 'commit <sha1> upstream.'
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
| -rw-r--r-- | sound/soc/sof/ipc4-topology.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/sound/soc/sof/ipc4-topology.c b/sound/soc/sof/ipc4-topology.c index 669b99a4f76e..3a5394c3dd83 100644 --- a/sound/soc/sof/ipc4-topology.c +++ b/sound/soc/sof/ipc4-topology.c @@ -1806,10 +1806,12 @@ static int sof_ipc4_route_setup(struct snd_sof_dev *sdev, struct snd_sof_route * int ret; if (!src_fw_module || !sink_fw_module) { - /* The NULL module will print as "(efault)" */ - dev_err(sdev->dev, "source %s or sink %s widget weren't set up properly\n", - src_fw_module->man4_module_entry.name, - sink_fw_module->man4_module_entry.name); + dev_err(sdev->dev, + "cannot bind %s -> %s, no firmware module for: %s%s\n", + src_widget->widget->name, sink_widget->widget->name, + src_fw_module ? "" : " source", + sink_fw_module ? "" : " sink"); + return -ENODEV; } |