aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrey Smirnov <[email protected]>2019-08-12 13:08:52 -0700
committerWim Van Sebroeck <[email protected]>2019-09-17 08:59:05 +0200
commitdc0dd28951f16be9714e90468e14566d186a7388 (patch)
treee4b6917eea58638d85357d76dbe14b884f1f78ae
parent08188e8dbc7587d58948efca493219515d6a5639 (diff)
watchdog: ziirave_wdt: Skip zeros when calculating checksum
Zeros don't contribute anything to checksum value, so we can skip unused portion of the packet when calculating its checksum. Signed-off-by: Andrey Smirnov <[email protected]> Cc: Chris Healy <[email protected]> Cc: Guenter Roeck <[email protected]> Cc: Rick Ramstetter <[email protected]> Cc: [email protected] Cc: [email protected] Reviewed-by: Guenter Roeck <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Guenter Roeck <[email protected]> Signed-off-by: Wim Van Sebroeck <[email protected]>
-rw-r--r--drivers/watchdog/ziirave_wdt.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/watchdog/ziirave_wdt.c b/drivers/watchdog/ziirave_wdt.c
index 9d9c669b8b47..19da0910c2d1 100644
--- a/drivers/watchdog/ziirave_wdt.c
+++ b/drivers/watchdog/ziirave_wdt.c
@@ -271,7 +271,7 @@ static int __ziirave_firm_write_pkt(struct watchdog_device *wdd,
memcpy(packet + 3, data, len);
/* Packet checksum */
- for (i = 0; i < ZIIRAVE_FIRM_PKT_TOTAL_SIZE - 1; i++)
+ for (i = 0; i < len + 3; i++)
checksum += packet[i];
packet[ZIIRAVE_FIRM_PKT_TOTAL_SIZE - 1] = checksum;