aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLecopzer Chen <[email protected]>2019-09-23 15:36:24 -0700
committerLinus Torvalds <[email protected]>2019-09-24 15:54:09 -0700
commitdb57e98d87908b8837352abe08515e42752270c1 (patch)
tree7071d2bd033dd5f3dd8a61554141faef96e79994
parentae83189405ea5c693683327fa69ac95a23ec59be (diff)
mm/sparse.c: fix ALIGN() without power of 2 in sparse_buffer_alloc()
The size argument passed into sparse_buffer_alloc() has already been aligned with PAGE_SIZE or PMD_SIZE. If the size after aligned is not power of 2 (e.g. 0x480000), the PTR_ALIGN() will return wrong value. Use roundup to round sparsemap_buf up to next multiple of size. Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Lecopzer Chen <[email protected]> Signed-off-by: Mark-PK Tsai <[email protected]> Cc: YJ Chiang <[email protected]> Cc: Lecopzer Chen <[email protected]> Cc: Pavel Tatashin <[email protected]> Cc: Oscar Salvador <[email protected]> Cc: Michal Hocko <[email protected]> Cc: Mike Rapoport <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
-rw-r--r--mm/sparse.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/mm/sparse.c b/mm/sparse.c
index 2bfd078301f8..79355a86064f 100644
--- a/mm/sparse.c
+++ b/mm/sparse.c
@@ -501,7 +501,7 @@ void * __meminit sparse_buffer_alloc(unsigned long size)
void *ptr = NULL;
if (sparsemap_buf) {
- ptr = PTR_ALIGN(sparsemap_buf, size);
+ ptr = (void *) roundup((unsigned long)sparsemap_buf, size);
if (ptr + size > sparsemap_buf_end)
ptr = NULL;
else {