diff options
| author | Bjorn Andersson <[email protected]> | 2023-07-17 09:55:38 -0700 |
|---|---|---|
| committer | Mathieu Poirier <[email protected]> | 2023-07-18 10:12:26 -0600 |
| commit | d629e5bcdfd9ba1c9da6da9144cc7ba43f04a6dc (patch) | |
| tree | 94a275173478a2c2668c2d1950c8f787e5b8186a | |
| parent | b5c9ee8296a3760760c7b5d2e305f91412adc795 (diff) | |
rpmsg: glink: Avoid dereferencing NULL channel
The newly introduced signal command handler checks for non-existing
channel and print an error message, but then continues on to dereference
that same channel.
Instead abort the handler when no channel is found.
Fixes: a2b73aa512a4 ("rpmsg: glink: Add support to handle signals command")
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>
Closes: https://lore.kernel.org/r/[email protected]/
Signed-off-by: Bjorn Andersson <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mathieu Poirier <[email protected]>
| -rw-r--r-- | drivers/rpmsg/qcom_glink_native.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c index e10c05ed21bb..82d460ff4777 100644 --- a/drivers/rpmsg/qcom_glink_native.c +++ b/drivers/rpmsg/qcom_glink_native.c @@ -1070,8 +1070,10 @@ static void qcom_glink_handle_signals(struct qcom_glink *glink, spin_lock_irqsave(&glink->idr_lock, flags); channel = idr_find(&glink->rcids, rcid); spin_unlock_irqrestore(&glink->idr_lock, flags); - if (!channel) + if (!channel) { dev_err(glink->dev, "signal for non-existing channel\n"); + return; + } enable = sigs & NATIVE_DSR_SIG || sigs & NATIVE_CTS_SIG; |