aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoel Colledge <[email protected]>2024-05-06 09:25:23 +0200
committerMike Snitzer <[email protected]>2024-05-09 09:10:58 -0400
commitd14646f23300a5fc85be867bafdc0702c2002789 (patch)
tree75bf34e9eb286c4790442352fbf17adf757039b0
parent8d24790ed08ab4e619ce58ed4a1b353ab77ffdc5 (diff)
dm-delay: fix hung task introduced by kthread mode
If the worker thread is not woken due to a bio, then it is not woken at all. This causes the hung task check to trigger. This occurs, for instance, when no bios are submitted. Also when a delay of 0 is configured, delay_bio() returns without waking the worker. Prevent the hung task check from triggering by creating the thread with kthread_run() instead of using kthread_create() directly. Fixes: 70bbeb29fab0 ("dm delay: for short delays, use kthread instead of timers and wq") Signed-off-by: Joel Colledge <[email protected]> Reviewed-by: Benjamin Marzinski <[email protected]> Signed-off-by: Mike Snitzer <[email protected]>
-rw-r--r--drivers/md/dm-delay.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/md/dm-delay.c b/drivers/md/dm-delay.c
index eec0daa4b227..4ba12d536994 100644
--- a/drivers/md/dm-delay.c
+++ b/drivers/md/dm-delay.c
@@ -269,8 +269,7 @@ out:
* In case of small requested delays, use kthread instead of
* timers and workqueue to achieve better latency.
*/
- dc->worker = kthread_create(&flush_worker_fn, dc,
- "dm-delay-flush-worker");
+ dc->worker = kthread_run(&flush_worker_fn, dc, "dm-delay-flush-worker");
if (IS_ERR(dc->worker)) {
ret = PTR_ERR(dc->worker);
dc->worker = NULL;