diff options
| author | Barry Song <[email protected]> | 2020-12-14 19:05:38 -0800 |
|---|---|---|
| committer | Linus Torvalds <[email protected]> | 2020-12-15 12:13:38 -0800 |
| commit | d0de82411864c4e1f24aaa3a653c7c08dd55c8d0 (patch) | |
| tree | 8ab00a9462556b4de8902ce9f176d553f5b7cb28 | |
| parent | afaa78886f218d840414c88c2eb7bb80666d79eb (diff) | |
mm/gup_test: GUP_TEST depends on DEBUG_FS
Without DEBUG_FS, all the code in gup_benchmark becomes meaningless.
For sure kernel provides debugfs stub while DEBUG_FS is disabled, but
the point here is that GUP_TEST can do nothing without DEBUG_FS.
[[email protected]: add comment as a prompt to users as commented by John and Randy]
Link: https://lkml.kernel.org/r/[email protected]
Link: https://lkml.kernel.org/r/[email protected]
Signed-off-by: Barry Song <[email protected]>
Suggested-by: John Garry <[email protected]>
Reviewed-by: John Hubbard <[email protected]>
Acked-by: Randy Dunlap <[email protected]>
Cc: Ralph Campbell <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
| -rw-r--r-- | mm/Kconfig | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/mm/Kconfig b/mm/Kconfig index 350f2e23a94a..5829d31649b9 100644 --- a/mm/Kconfig +++ b/mm/Kconfig @@ -823,6 +823,7 @@ config PERCPU_STATS config GUP_TEST bool "Enable infrastructure for get_user_pages()-related unit tests" + depends on DEBUG_FS help Provides /sys/kernel/debug/gup_test, which in turn provides a way to make ioctl calls that can launch kernel-based unit tests for @@ -840,6 +841,9 @@ config GUP_TEST See tools/testing/selftests/vm/gup_test.c +comment "GUP_TEST needs to have DEBUG_FS enabled" + depends on !GUP_TEST && !DEBUG_FS + config GUP_GET_PTE_LOW_HIGH bool |