diff options
| author | Alexander Usyskin <[email protected]> | 2014-08-25 16:46:53 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2014-09-23 22:59:10 -0700 |
| commit | cfda2794b5afe7ce64ee9605c64bef0e56a48125 (patch) | |
| tree | 6585c76203157fe7309a3939af94059d0b625cb0 | |
| parent | 154eb18fedd5219516887a7e2bf2825b1b06ff2b (diff) | |
mei: bus: fix possible boundaries violation
function 'strncpy' will fill whole buffer 'id.name' of fixed size (32)
with string value and will not leave place for NULL-terminator.
Possible buffer boundaries violation in following string operations.
Replace strncpy with strlcpy.
Cc: [email protected] # 3.10+
Signed-off-by: Alexander Usyskin <[email protected]>
Signed-off-by: Tomas Winkler <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
| -rw-r--r-- | drivers/misc/mei/bus.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c index 09dad2df7aae..1cf3a72f2954 100644 --- a/drivers/misc/mei/bus.c +++ b/drivers/misc/mei/bus.c @@ -70,7 +70,7 @@ static int mei_cl_device_probe(struct device *dev) dev_dbg(dev, "Device probe\n"); - strncpy(id.name, dev_name(dev), sizeof(id.name)); + strlcpy(id.name, dev_name(dev), sizeof(id.name)); return driver->probe(device, &id); } |