diff options
| author | Uwe Kleine-König <[email protected]> | 2022-06-07 17:24:56 +0200 |
|---|---|---|
| committer | Miquel Raynal <[email protected]> | 2022-06-09 15:06:34 +0200 |
| commit | cfa7847f150c4343903d8ff2cd219418c1768205 (patch) | |
| tree | 841d24a7380395f00e332e48f21016104433c987 | |
| parent | 28607b426c3d050714f250d0faeb99d2e9106e90 (diff) | |
mtd: st_spi_fsm: Warn about failure to unregister mtd device
mtd_device_unregister() shouldn't fail. Wail loudly if it does anyhow.
This matches how other drivers (e.g. nand/raw/nandsim.c) use
mtd_device_unregister().
By returning 0 in the platform remove callback a generic error message
by the device core is suppressed, nothing else changes.
This is a preparation for making platform remove callbacks return void.
Signed-off-by: Uwe Kleine-König <[email protected]>
Signed-off-by: Miquel Raynal <[email protected]>
Link: https://lore.kernel.org/linux-mtd/[email protected]
| -rw-r--r-- | drivers/mtd/devices/st_spi_fsm.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/mtd/devices/st_spi_fsm.c b/drivers/mtd/devices/st_spi_fsm.c index 52a799cae402..a5a4b612480c 100644 --- a/drivers/mtd/devices/st_spi_fsm.c +++ b/drivers/mtd/devices/st_spi_fsm.c @@ -2130,7 +2130,9 @@ static int stfsm_remove(struct platform_device *pdev) clk_disable_unprepare(fsm->clk); - return mtd_device_unregister(&fsm->mtd); + WARN_ON(mtd_device_unregister(&fsm->mtd)); + + return 0; } #ifdef CONFIG_PM_SLEEP |