diff options
| author | Fabio Estevam <[email protected]> | 2016-02-17 09:42:13 -0200 |
|---|---|---|
| committer | Mark Brown <[email protected]> | 2016-02-17 13:10:38 +0000 |
| commit | cd890ade492784ae06dadd20e688ba1760d3c801 (patch) | |
| tree | a3f4b90140240b54322749fc41e07734013e9bd2 | |
| parent | 478f544e5b5538ccbcfdb18b4e9860a2f61ab921 (diff) | |
ASoC: hdac_hdmi: Remove 'edev' NULL check
Commit 4a3478debf36 ("ASoC: hdac_hdmi: Add jack reporting")
leads to the following Smatch complaint:
sound/soc/codecs/hdac_hdmi.c:971 hdac_hdmi_present_sense()
warn: variable dereferenced before check 'edev' (see line 967)
As explained by Subhransu S. Prusty:
"This NULL check is not required, can be removed.
edev object is expected to be present when the present_sense is
called. This is called from places where this edev object is
already available."
So remove the evdev NULL check.
Reported-by: Dan Carpenter <[email protected]>
Signed-off-by: Fabio Estevam <[email protected]>
Acked-by: Subhransu S. Prusty <[email protected]>
Signed-off-by: Mark Brown <[email protected]>
| -rw-r--r-- | sound/soc/codecs/hdac_hdmi.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/sound/soc/codecs/hdac_hdmi.c b/sound/soc/codecs/hdac_hdmi.c index 36f12004ae9c..2884dbf0bc07 100644 --- a/sound/soc/codecs/hdac_hdmi.c +++ b/sound/soc/codecs/hdac_hdmi.c @@ -968,9 +968,6 @@ static void hdac_hdmi_present_sense(struct hdac_hdmi_pin *pin, int repoll) struct hdac_hdmi_pcm *pcm; int val; - if (!edev) - return; - pin->repoll_count = repoll; pm_runtime_get_sync(&edev->hdac.dev); |