diff options
| author | Martin Habets <[email protected]> | 2022-05-19 08:17:15 +0100 |
|---|---|---|
| committer | Jakub Kicinski <[email protected]> | 2022-05-20 16:46:49 -0700 |
| commit | cc398a34d16fd90a2dcc59b1105c634f038ea53b (patch) | |
| tree | 57c1f323d1c04d81e0b49c3d6eaa701728f29f10 | |
| parent | dc7769244e03e932262a4f10eeab11657cb601c7 (diff) | |
sfc/siena: Remove duplicate check on segments
Siena only supports software TSO. This means more code can be deleted,
as pointed out by the Smatch static checker warning:
drivers/net/ethernet/sfc/siena/tx.c:184 __efx_siena_enqueue_skb()
warn: duplicate check 'segments' (previous on line 158)
Fixes: 956f2d86cb37 ("sfc/siena: Remove build references to missing functionality")
Reported-by: Dan Carpenter <[email protected]>
Link: https://lore.kernel.org/kernel-janitors/YoH5tJMnwuGTrn1Z@kili/
Signed-off-by: Martin Habets <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
| -rw-r--r-- | drivers/net/ethernet/sfc/siena/tx.c | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/drivers/net/ethernet/sfc/siena/tx.c b/drivers/net/ethernet/sfc/siena/tx.c index b84b9e348c13..e166dcb9b99c 100644 --- a/drivers/net/ethernet/sfc/siena/tx.c +++ b/drivers/net/ethernet/sfc/siena/tx.c @@ -181,14 +181,7 @@ netdev_tx_t __efx_siena_enqueue_skb(struct efx_tx_queue *tx_queue, if (__netdev_tx_sent_queue(tx_queue->core_txq, skb_len, xmit_more)) efx_tx_send_pending(tx_queue->channel); - if (segments) { - tx_queue->tso_bursts++; - tx_queue->tso_packets += segments; - tx_queue->tx_packets += segments; - } else { - tx_queue->tx_packets++; - } - + tx_queue->tx_packets++; return NETDEV_TX_OK; |