diff options
| author | Kuan-Wei Chiu <[email protected]> | 2024-08-13 01:02:29 +0800 |
|---|---|---|
| committer | Andrew Morton <[email protected]> | 2024-09-01 20:43:33 -0700 |
| commit | cbf164cd44e06c78938b4a4a4479d3541779c319 (patch) | |
| tree | 92fbe8efae109927b1c172177447e9cb6b11ccc4 | |
| parent | ccbfd2df3018e2694f750abe5e93b647a4eef5b1 (diff) | |
lib/bcd: optimize _bin2bcd() for improved performance
The original _bin2bcd() function used / 10 and % 10 operations for
conversion. Although GCC optimizes these operations and does not generate
division or modulus instructions, the new implementation reduces the
number of mov instructions in the generated code for both x86-64 and ARM
architectures.
This optimization calculates the tens digit using (val * 103) >> 10, which
is accurate for values of 'val' in the range [0, 178]. Given that the
valid input range is [0, 99], this method ensures correctness while
simplifying the generated code.
Link: https://lkml.kernel.org/r/[email protected]
Signed-off-by: Kuan-Wei Chiu <[email protected]>
Cc: Ching-Chun (Jim) Huang <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
| -rw-r--r-- | lib/bcd.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/lib/bcd.c b/lib/bcd.c index 7e4750b6e801..c5e79ba9cd7b 100644 --- a/lib/bcd.c +++ b/lib/bcd.c @@ -10,6 +10,8 @@ EXPORT_SYMBOL(_bcd2bin); unsigned char _bin2bcd(unsigned val) { - return ((val / 10) << 4) + val % 10; + const unsigned int t = (val * 103) >> 10; + + return (t << 4) | (val - t * 10); } EXPORT_SYMBOL(_bin2bcd); |