diff options
| author | Zheng Bin <[email protected]> | 2020-06-15 09:21:53 +0800 |
|---|---|---|
| committer | Dominique Martinet <[email protected]> | 2020-07-19 14:58:47 +0200 |
| commit | cb0aae0e31c632c407a2cab4307be85a001d4d98 (patch) | |
| tree | 36921853f7a5edc29257652cf23fbd77f1caeef3 | |
| parent | 66246641609b3cbfc87e805ded1f018b5c9cecf4 (diff) | |
9p: Fix memory leak in v9fs_mount
v9fs_mount
v9fs_session_init
v9fs_cache_session_get_cookie
v9fs_random_cachetag -->alloc cachetag
v9ses->fscache = fscache_acquire_cookie -->maybe NULL
sb = sget -->fail, goto clunk
clunk_fid:
v9fs_session_close
if (v9ses->fscache) -->NULL
kfree(v9ses->cachetag)
Thus memleak happens.
Link: http://lkml.kernel.org/r/[email protected]
Fixes: 60e78d2c993e ("9p: Add fscache support to 9p")
Cc: <[email protected]> # v2.6.32+
Signed-off-by: Zheng Bin <[email protected]>
Signed-off-by: Dominique Martinet <[email protected]>
| -rw-r--r-- | fs/9p/v9fs.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/fs/9p/v9fs.c b/fs/9p/v9fs.c index 15a99f9c7253..39def020a074 100644 --- a/fs/9p/v9fs.c +++ b/fs/9p/v9fs.c @@ -500,10 +500,9 @@ void v9fs_session_close(struct v9fs_session_info *v9ses) } #ifdef CONFIG_9P_FSCACHE - if (v9ses->fscache) { + if (v9ses->fscache) v9fs_cache_session_put_cookie(v9ses); - kfree(v9ses->cachetag); - } + kfree(v9ses->cachetag); #endif kfree(v9ses->uname); kfree(v9ses->aname); |