diff options
| author | Quanfa Fu <[email protected]> | 2023-02-21 08:52:42 +0900 |
|---|---|---|
| committer | Masami Hiramatsu (Google) <[email protected]> | 2023-02-21 08:52:42 +0900 |
| commit | c96abaec78f34366b3ddf1c6be52ca5c1241e15b (patch) | |
| tree | 818396f7971dc8ef6883abf4cbf78728206d9eba | |
| parent | 1fcd09fd4f8494b05b7c34971f3498dda0bb06ee (diff) | |
tracing/eprobe: no need to check for negative ret value for snprintf
No need to check for negative return value from snprintf() as the
code does not return negative values.
Link: https://lore.kernel.org/all/[email protected]/
Signed-off-by: Quanfa Fu <[email protected]>
Acked-by: Masami Hiramatsu (Google) <[email protected]>
Reviewed-by: Steven Rostedt (Google) <[email protected]>
Signed-off-by: Masami Hiramatsu (Google) <[email protected]>
| -rw-r--r-- | kernel/trace/trace_eprobe.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/kernel/trace/trace_eprobe.c b/kernel/trace/trace_eprobe.c index 352b65e2b910..594ac1d086aa 100644 --- a/kernel/trace/trace_eprobe.c +++ b/kernel/trace/trace_eprobe.c @@ -923,17 +923,13 @@ static int trace_eprobe_parse_filter(struct trace_eprobe *ep, int argc, const ch p = ep->filter_str; for (i = 0; i < argc; i++) { - ret = snprintf(p, len, "%s ", argv[i]); - if (ret < 0) - goto error; - if (ret > len) { - ret = -E2BIG; - goto error; - } + if (i) + ret = snprintf(p, len, " %s", argv[i]); + else + ret = snprintf(p, len, "%s", argv[i]); p += ret; len -= ret; } - p[-1] = '\0'; /* * Ensure the filter string can be parsed correctly. Note, this |