aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTang Bin <[email protected]>2020-05-08 19:43:05 +0800
committerGreg Kroah-Hartman <[email protected]>2020-05-13 14:20:01 +0200
commitc856b4b0fdb5044bca4c0acf9a66f3b5cc01a37a (patch)
tree12fb01a7d0ac4af8a2a5cfcd8d583f0c6a662f32
parent09806eba8279376de481c74bc1a2090283db757d (diff)
USB: EHCI: ehci-mv: fix error handling in mv_ehci_probe()
If the function platform_get_irq() failed, the negative value returned will not be detected here. So fix error handling in mv_ehci_probe(). And when get irq failed, the function platform_get_irq() logs an error message, so remove redundant message here. Signed-off-by: Zhang Shengju <[email protected]> Signed-off-by: Tang Bin <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
-rw-r--r--drivers/usb/host/ehci-mv.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c
index 8f692fe17f45..0d61f43c29dc 100644
--- a/drivers/usb/host/ehci-mv.c
+++ b/drivers/usb/host/ehci-mv.c
@@ -167,9 +167,8 @@ static int mv_ehci_probe(struct platform_device *pdev)
hcd->regs = ehci_mv->op_regs;
hcd->irq = platform_get_irq(pdev, 0);
- if (!hcd->irq) {
- dev_err(&pdev->dev, "Cannot get irq.");
- retval = -ENODEV;
+ if (hcd->irq < 0) {
+ retval = hcd->irq;
goto err_disable_clk;
}