diff options
| author | Bo Liu <[email protected]> | 2023-01-17 20:29:44 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2023-01-20 13:07:54 +0100 |
| commit | c7109c72ab92dd6934b9ff8d45cb7e86f7a7ba0d (patch) | |
| tree | d75ceb21f352d75f4e651cdcf380b5b8fdf0d1e9 | |
| parent | c6e29fe5e08ce177b8a1a77aa99c59da2f166044 (diff) | |
virtio_console: Use strscpy() to instead of strncpy()
The implementation of strscpy() is more robust and safer.
That's now the recommended way to copy NUL-terminated strings.
Signed-off-by: Bo Liu <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
| -rw-r--r-- | drivers/char/virtio_console.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 6a821118d553..d5ac4d955bc8 100644 --- a/drivers/char/virtio_console.c +++ b/drivers/char/virtio_console.c @@ -1666,9 +1666,8 @@ static void handle_control_message(struct virtio_device *vdev, "Not enough space to store port name\n"); break; } - strncpy(port->name, buf->buf + buf->offset + sizeof(*cpkt), - name_size - 1); - port->name[name_size - 1] = 0; + strscpy(port->name, buf->buf + buf->offset + sizeof(*cpkt), + name_size); /* * Since we only have one sysfs attribute, 'name', |