diff options
| author | Kevin Lo <[email protected]> | 2021-10-21 14:32:27 +0800 |
|---|---|---|
| committer | Kalle Valo <[email protected]> | 2021-10-27 10:37:01 +0300 |
| commit | c6477cb237048725922f6a786f68b5232abb418f (patch) | |
| tree | 8507c15a3f57382760710792cad9678766d8e426 | |
| parent | 090f8a2f7b38f3a1dcf202437e5307761e8e4625 (diff) | |
rtw89: fix return value in hfc_pub_cfg_chk
It seems to me when pub_cfg->grp0 + pub_cfg->grp1 != pub_cfg->pub_max is true,
it should return -EFAULT rather than 0. Otherwise, the function doesn't need
to exist.
Signed-off-by: Kevin Lo <[email protected]>
Acked-by: Ping-Ke Shih <[email protected]>
Signed-off-by: Kalle Valo <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
| -rw-r--r-- | drivers/net/wireless/realtek/rtw89/mac.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/realtek/rtw89/mac.c b/drivers/net/wireless/realtek/rtw89/mac.c index 69384c43c046..afcd07ab1de7 100644 --- a/drivers/net/wireless/realtek/rtw89/mac.c +++ b/drivers/net/wireless/realtek/rtw89/mac.c @@ -560,7 +560,7 @@ static int hfc_pub_cfg_chk(struct rtw89_dev *rtwdev) const struct rtw89_hfc_pub_cfg *pub_cfg = ¶m->pub_cfg; if (pub_cfg->grp0 + pub_cfg->grp1 != pub_cfg->pub_max) - return 0; + return -EFAULT; return 0; } |