aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorXiongfeng Wang <[email protected]>2022-11-18 14:31:34 +0800
committerPeter Zijlstra <[email protected]>2022-11-24 11:09:24 +0100
commitc508eb042d9739bf9473526f53303721b70e9100 (patch)
treedb65bd9cd139c5d130d028c16d4480d8ce0d0136
parentd5b73506b5b1b4a6e675c54b7977ea08e64cba19 (diff)
perf/x86/intel/uncore: Fix reference count leak in sad_cfg_iio_topology()
pci_get_device() will increase the reference count for the returned pci_dev, and also decrease the reference count for the input parameter *from* if it is not NULL. If we break the loop in sad_cfg_iio_topology() with 'dev' not NULL. We need to call pci_dev_put() to decrease the reference count. Since pci_dev_put() can handle the NULL input parameter, we can just add one pci_dev_put() right before 'return ret'. Fixes: c1777be3646b ("perf/x86/intel/uncore: Enable I/O stacks to IIO PMON mapping on SNR") Signed-off-by: Xiongfeng Wang <[email protected]> Signed-off-by: Peter Zijlstra (Intel) <[email protected]> Reviewed-by: Kan Liang <[email protected]> Link: https://lore.kernel.org/r/[email protected]
-rw-r--r--arch/x86/events/intel/uncore_snbep.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/arch/x86/events/intel/uncore_snbep.c b/arch/x86/events/intel/uncore_snbep.c
index b8f9bd150b42..b14d59183516 100644
--- a/arch/x86/events/intel/uncore_snbep.c
+++ b/arch/x86/events/intel/uncore_snbep.c
@@ -4743,6 +4743,8 @@ static int sad_cfg_iio_topology(struct intel_uncore_type *type, u8 *sad_pmon_map
type->topology[die][stack_id].iio->pci_bus_no = dev->bus->number;
}
+ pci_dev_put(dev);
+
return ret;
}