aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGreg Kroah-Hartman <[email protected]>2018-05-29 18:08:01 +0200
committerStephen Boyd <[email protected]>2018-06-01 19:22:29 -0700
commitc0526a111afd564b79f28ce932c2bb101be42937 (patch)
tree8b464d158a3e67492ba7b6eb5c66bae6a6e1e214
parent8a26bbbb932021fd6ce8821ca8b2e6771b8ff7d2 (diff)
clk: bcm2835: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Michael Turquette <[email protected]> Reviewed-by: Eric Anholt <[email protected]> Cc: Stefan Wahren <[email protected]> Cc: Florian Fainelli <[email protected]> Cc: Ray Jui <[email protected]> Cc: Scott Branden <[email protected]> Cc: [email protected] Cc: Phil Elwell <[email protected]> Cc: Boris Brezillon <[email protected]> Cc: Greg Kroah-Hartman <[email protected]> Cc: Danilo Krummrich <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: Stephen Boyd <[email protected]>
-rw-r--r--drivers/clk/bcm/clk-bcm2835.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c
index fa0d5c8611a0..1329440af59f 100644
--- a/drivers/clk/bcm/clk-bcm2835.c
+++ b/drivers/clk/bcm/clk-bcm2835.c
@@ -398,7 +398,6 @@ static int bcm2835_debugfs_regset(struct bcm2835_cprman *cprman, u32 base,
struct debugfs_reg32 *regs, size_t nregs,
struct dentry *dentry)
{
- struct dentry *regdump;
struct debugfs_regset32 *regset;
regset = devm_kzalloc(cprman->dev, sizeof(*regset), GFP_KERNEL);
@@ -409,10 +408,9 @@ static int bcm2835_debugfs_regset(struct bcm2835_cprman *cprman, u32 base,
regset->nregs = nregs;
regset->base = cprman->regs + base;
- regdump = debugfs_create_regset32("regdump", S_IRUGO, dentry,
- regset);
+ debugfs_create_regset32("regdump", S_IRUGO, dentry, regset);
- return regdump ? 0 : -ENOMEM;
+ return 0;
}
struct bcm2835_pll_data {