diff options
| author | Jason A. Donenfeld <[email protected]> | 2022-04-08 18:03:13 +0200 |
|---|---|---|
| committer | Jason A. Donenfeld <[email protected]> | 2022-05-13 23:59:23 +0200 |
| commit | c04e72700f2293013dab40208e809369378f224c (patch) | |
| tree | b72da37965008e55da5b594ec08681ab7a7adfaa | |
| parent | ff8a8f59c99f6a7c656387addc4d9f2247d75077 (diff) | |
nios2: use fallback for random_get_entropy() instead of zero
In the event that random_get_entropy() can't access a cycle counter or
similar, falling back to returning 0 is really not the best we can do.
Instead, at least calling random_get_entropy_fallback() would be
preferable, because that always needs to return _something_, even
falling back to jiffies eventually. It's not as though
random_get_entropy_fallback() is super high precision or guaranteed to
be entropic, but basically anything that's not zero all the time is
better than returning zero all the time.
Cc: Thomas Gleixner <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Acked-by: Dinh Nguyen <[email protected]>
Signed-off-by: Jason A. Donenfeld <[email protected]>
| -rw-r--r-- | arch/nios2/include/asm/timex.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/arch/nios2/include/asm/timex.h b/arch/nios2/include/asm/timex.h index a769f871b28d..40a1adc9bd03 100644 --- a/arch/nios2/include/asm/timex.h +++ b/arch/nios2/include/asm/timex.h @@ -8,5 +8,8 @@ typedef unsigned long cycles_t; extern cycles_t get_cycles(void); +#define get_cycles get_cycles + +#define random_get_entropy() (((unsigned long)get_cycles()) ?: random_get_entropy_fallback()) #endif |