aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorfarah kassabri <[email protected]>2023-06-04 11:19:19 +0300
committerOded Gabbay <[email protected]>2023-10-09 12:37:18 +0300
commitbffd2f16ae374decdeb5bc714b1aa2e0c23f3708 (patch)
tree51c5607bc8cb6cce40b4356a8f207cadcf71996f
parent43d8acce607c90a44653c80f3bf211f31abc0416 (diff)
accel/habanalabs: fix standalone preboot descriptor request
The preboot used to statically allocate memory for the comms descriptor on the device memory when driver requested the descriptor information. Now preboot moved to dynamic memory allocation where it wants to check the size the driver expects vs. what the f/w expects. Note there are no backward compatibility issues as older f/w versions simply ignore this value. Signed-off-by: farah kassabri <[email protected]> Reviewed-by: Oded Gabbay <[email protected]> Signed-off-by: Oded Gabbay <[email protected]>
-rw-r--r--drivers/accel/habanalabs/common/firmware_if.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/accel/habanalabs/common/firmware_if.c b/drivers/accel/habanalabs/common/firmware_if.c
index acbc1a6b5cb1..370508e98854 100644
--- a/drivers/accel/habanalabs/common/firmware_if.c
+++ b/drivers/accel/habanalabs/common/firmware_if.c
@@ -2743,7 +2743,8 @@ static int hl_fw_dynamic_init_cpu(struct hl_device *hdev,
if (!(hdev->fw_components & FW_TYPE_BOOT_CPU)) {
struct lkd_fw_binning_info *binning_info;
- rc = hl_fw_dynamic_request_descriptor(hdev, fw_loader, 0);
+ rc = hl_fw_dynamic_request_descriptor(hdev, fw_loader,
+ sizeof(struct lkd_msg_comms));
if (rc)
goto protocol_err;