diff options
| author | Yuan Can <[email protected]> | 2022-08-15 03:14:23 +0000 |
|---|---|---|
| committer | Joerg Roedel <[email protected]> | 2022-09-07 10:52:47 +0200 |
| commit | bf75eb44e11bcdb1edda3305dc7292b605c25172 (patch) | |
| tree | 526193d61ec7f0adbdaf8b8467ab015c53d49667 | |
| parent | 283945017cbf685546ba7d065f254ad77eb888b1 (diff) | |
iommu: Remove duplicate ida_free in iommu_group_alloc
In the iommu_group_alloc, when the kobject_init_and_add
failed, the group->kobj is associate with iommu_group_ktype,
thus its release function iommu_group_release will be called
by the following kobject_put. The iommu_group_release calls
ida_free with the group->id, so we do not need to do it before
kobject_put.
Signed-off-by: Yuan Can <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Joerg Roedel <[email protected]>
| -rw-r--r-- | drivers/iommu/iommu.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index 31b5f4ceb2e9..12e49dcf91bd 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -654,7 +654,6 @@ struct iommu_group *iommu_group_alloc(void) ret = kobject_init_and_add(&group->kobj, &iommu_group_ktype, NULL, "%d", group->id); if (ret) { - ida_free(&iommu_group_ida, group->id); kobject_put(&group->kobj); return ERR_PTR(ret); } |