diff options
| author | Michał Winiarski <[email protected]> | 2023-12-05 02:33:06 +0100 |
|---|---|---|
| committer | Rodrigo Vivi <[email protected]> | 2023-12-21 11:45:12 -0500 |
| commit | bf2d0d88c3b8d325eee670b2e0b4545de6d30998 (patch) | |
| tree | 6bce19a6558bfc4112cda560b05829f122aade67 | |
| parent | c93ea05191c5b67ecaa784085f8a73e02abcfc76 (diff) | |
drm/xe/uc: Store firmware binary in system-memory backed BO
The firmware loading for GuC is about to be moved, and will happen much
earlier in the probe process, when local-memory is not yet available.
While this has the potential to make the firmware loading process
slower, this is only happening during probe and full device reset.
Since both are not hot-paths - store all UC-like firmware in system
memory.
Signed-off-by: Michał Winiarski <[email protected]>
Reviewed-by: Matt Roper <[email protected]>
Signed-off-by: Rodrigo Vivi <[email protected]>
| -rw-r--r-- | drivers/gpu/drm/xe/xe_uc_fw.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/gpu/drm/xe/xe_uc_fw.c b/drivers/gpu/drm/xe/xe_uc_fw.c index f258eb44fe31..9abae65c6b23 100644 --- a/drivers/gpu/drm/xe/xe_uc_fw.c +++ b/drivers/gpu/drm/xe/xe_uc_fw.c @@ -750,8 +750,6 @@ fail: int xe_uc_fw_init(struct xe_uc_fw *uc_fw) { const struct firmware *fw = NULL; - struct xe_gt *gt = uc_fw_to_gt(uc_fw); - struct xe_tile *tile = gt_to_tile(gt); int err; err = uc_fw_request(uc_fw, &fw); @@ -763,7 +761,7 @@ int xe_uc_fw_init(struct xe_uc_fw *uc_fw) return 0; err = uc_fw_copy(uc_fw, fw->data, fw->size, - XE_BO_CREATE_VRAM_IF_DGFX(tile) | XE_BO_CREATE_GGTT_BIT); + XE_BO_CREATE_SYSTEM_BIT | XE_BO_CREATE_GGTT_BIT); uc_fw_release(fw); |