diff options
| author | Deepak R Varma <[email protected]> | 2023-01-27 22:01:49 +0530 |
|---|---|---|
| committer | Hans de Goede <[email protected]> | 2023-02-03 10:01:50 +0100 |
| commit | bdf2ffb6be35d1ae48cb4b7785a9f0427b601017 (patch) | |
| tree | e3b4d0b4c7c5e43ffe34948dcda7c8ba6ba60496 | |
| parent | cf2cc541423f51731c5844dddb0699e301616a86 (diff) | |
platform/x86: dell-smo8800: Use min_t() for comparison and assignment
Simplify code by using min_t helper macro for logical evaluation
and value assignment. Use the _t variant of min macro since the
variable types are not same.
This issue is identified by coccicheck using the minmax.cocci file.
Signed-off-by: Deepak R Varma <[email protected]>
Acked-by: Pali Rohár <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Reviewed-by: Hans de Goede <[email protected]>
Signed-off-by: Hans de Goede <[email protected]>
| -rw-r--r-- | drivers/platform/x86/dell/dell-smo8800.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/platform/x86/dell/dell-smo8800.c b/drivers/platform/x86/dell/dell-smo8800.c index 3385e852104c..8d6b7a83cf24 100644 --- a/drivers/platform/x86/dell/dell-smo8800.c +++ b/drivers/platform/x86/dell/dell-smo8800.c @@ -67,10 +67,7 @@ static ssize_t smo8800_misc_read(struct file *file, char __user *buf, retval = 1; - if (data < 255) - byte_data = data; - else - byte_data = 255; + byte_data = min_t(u32, data, 255); if (put_user(byte_data, buf)) retval = -EFAULT; |