aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLuca Tettamanti <[email protected]>2011-05-25 20:43:31 +0200
committerJean Delvare <[email protected]>2011-05-25 20:43:31 +0200
commitbc1f419c76a2d6450413ce4349f4e4a07be011d5 (patch)
treeb89b92a6eca16ddd70336da9e26659b6b2414a90
parent4a7df24ddc7097cd789a7527187826552ea0765e (diff)
i8k: Avoid lahf in 64-bit code
i8k uses lahf to read the flag register in 64-bit code; early x86-64 CPUs, however, lack this instruction and we get an invalid opcode exception at runtime. Use pushf to load the flag register into the stack instead. Signed-off-by: Luca Tettamanti <[email protected]> Reported-by: Jeff Rickman <[email protected]> Tested-by: Jeff Rickman <[email protected]> Tested-by: Harry G McGavran Jr <[email protected]> Cc: [email protected] Cc: Massimo Dal Zotto <[email protected]> Signed-off-by: Jean Delvare <[email protected]>
-rw-r--r--drivers/char/i8k.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/char/i8k.c b/drivers/char/i8k.c
index d72433f2d310..ee017166545e 100644
--- a/drivers/char/i8k.c
+++ b/drivers/char/i8k.c
@@ -139,8 +139,8 @@ static int i8k_smm(struct smm_regs *regs)
"movl %%edi,20(%%rax)\n\t"
"popq %%rdx\n\t"
"movl %%edx,0(%%rax)\n\t"
- "lahf\n\t"
- "shrl $8,%%eax\n\t"
+ "pushfq\n\t"
+ "popq %%rax\n\t"
"andl $1,%%eax\n"
:"=a"(rc)
: "a"(regs)