diff options
| author | Sean Christopherson <[email protected]> | 2023-01-07 01:10:20 +0000 |
|---|---|---|
| committer | Sean Christopherson <[email protected]> | 2023-01-24 10:04:34 -0800 |
| commit | ba5838abb05334e4abfdff1490585c7f365e0424 (patch) | |
| tree | 034708f8363408a07d62a5bfdd9b1da412da6fa3 | |
| parent | 85e64d09f7934166b77dfbe42eec600c93703cb3 (diff) | |
KVM: x86: Inject #GP if WRMSR sets reserved bits in APIC Self-IPI
Inject a #GP if the guest attempts to set reserved bits in the x2APIC-only
Self-IPI register. Bits 7:0 hold the vector, all other bits are reserved.
Reported-by: Marc Orr <[email protected]>
Cc: Ben Gardon <[email protected]>
Cc: Venkatesh Srinivas <[email protected]>
Cc: [email protected]
Reviewed-by: Maxim Levitsky <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Sean Christopherson <[email protected]>
| -rw-r--r-- | arch/x86/kvm/lapic.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c index 08450b3e7040..9aca006b2d22 100644 --- a/arch/x86/kvm/lapic.c +++ b/arch/x86/kvm/lapic.c @@ -2324,10 +2324,14 @@ static int kvm_lapic_reg_write(struct kvm_lapic *apic, u32 reg, u32 val) break; case APIC_SELF_IPI: - if (apic_x2apic_mode(apic)) - kvm_apic_send_ipi(apic, APIC_DEST_SELF | (val & APIC_VECTOR_MASK), 0); - else + /* + * Self-IPI exists only when x2APIC is enabled. Bits 7:0 hold + * the vector, everything else is reserved. + */ + if (!apic_x2apic_mode(apic) || (val & ~APIC_VECTOR_MASK)) ret = 1; + else + kvm_apic_send_ipi(apic, APIC_DEST_SELF | val, 0); break; default: ret = 1; |