aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBean Huo <[email protected]>2020-01-20 14:08:13 +0100
committerMartin K. Petersen <[email protected]>2020-01-20 19:14:53 -0500
commitb9fc5320212efdfb4e08b825aaa007815fd11d16 (patch)
tree9ddb4eb32b4fcfc536064821ae72c31381cda121
parentfdb2c232497296025c27e47d379fe55ba46ff9e6 (diff)
scsi: ufs: Fix ufshcd_probe_hba() reture value in case ufshcd_scsi_add_wlus() fails
A non-zero error value likely being returned by ufshcd_scsi_add_wlus() in case of failure of adding the WLs, but ufshcd_probe_hba() doesn't use this value, and doesn't report this failure to upper caller. This patch is to fix this issue. Fixes: 2a8fa600445c ("ufs: manually add well known logical units") Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Asutosh Das <[email protected]> Reviewed-by: Alim Akhtar <[email protected]> Reviewed-by: Stanley Chu <[email protected]> Signed-off-by: Bean Huo <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
-rw-r--r--drivers/scsi/ufs/ufshcd.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 1168baf358ea..a2f17df9dc4c 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -7035,7 +7035,8 @@ static int ufshcd_probe_hba(struct ufs_hba *hba)
ufshcd_init_icc_levels(hba);
/* Add required well known logical units to scsi mid layer */
- if (ufshcd_scsi_add_wlus(hba))
+ ret = ufshcd_scsi_add_wlus(hba);
+ if (ret)
goto out;
/* Initialize devfreq after UFS device is detected */