aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorXunlei Pang <[email protected]>2016-07-09 15:54:22 +0800
committerIngo Molnar <[email protected]>2016-08-10 13:32:55 +0200
commitb8922125e4790fa237a8a4204562ecf457ef54bb (patch)
tree4f11d2a54e54d5e1f5f2ec913df7a18723427f1f
parenta23eadfae2fd45536a355b785d5a1533e1955c22 (diff)
sched/fair: Fix typo in sync_throttle()
We should update cfs_rq->throttled_clock_task, not pcfs_rq->throttle_clock_task. The effects of this bug was probably occasionally erratic group scheduling, particularly in cgroups-intense workloads. Signed-off-by: Xunlei Pang <[email protected]> [ Added changelog. ] Signed-off-by: Peter Zijlstra (Intel) <[email protected]> Acked-by: Konstantin Khlebnikov <[email protected]> Cc: Linus Torvalds <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Thomas Gleixner <[email protected]> Fixes: 55e16d30bd99 ("sched/fair: Rework throttle_count sync") Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Ingo Molnar <[email protected]>
-rw-r--r--kernel/sched/fair.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 4088eedea763..039de34f1521 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -4269,7 +4269,7 @@ static void sync_throttle(struct task_group *tg, int cpu)
pcfs_rq = tg->parent->cfs_rq[cpu];
cfs_rq->throttle_count = pcfs_rq->throttle_count;
- pcfs_rq->throttled_clock_task = rq_clock_task(cpu_rq(cpu));
+ cfs_rq->throttled_clock_task = rq_clock_task(cpu_rq(cpu));
}
/* conditionally throttle active cfs_rq's from put_prev_entity() */