diff options
| author | Arend van Spriel <arend.vanspriel@broadcom.com> | 2024-01-06 11:38:34 +0100 |
|---|---|---|
| committer | Kalle Valo <kvalo@kernel.org> | 2024-01-19 19:30:18 +0200 |
| commit | b822015a1f57268f5b2ff656736dc4004e7097da (patch) | |
| tree | 5d84ed4a54a0a37b9aea9b43c91a8849a49ba436 | |
| parent | 85da8f71aaa7b83ea7ef0e89182e0cd47e16d465 (diff) | |
wifi: brcmfmac: avoid invalid list operation when vendor attach fails
When the brcmf_fwvid_attach() fails the driver instance is not added
to the vendor list. Hence we should not try to delete it from that
list when the brcmf_fwvid_detach() function is called in cleanup path.
Cc: stable@vger.kernel.org # 6.2.x
Fixes: d6a5c562214f ("wifi: brcmfmac: add support for vendor-specific firmware api")
Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://msgid.link/20240106103835.269149-3-arend.vanspriel@broadcom.com
| -rw-r--r-- | drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwvid.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwvid.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwvid.c index f633e2bbd891..b427782554b5 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwvid.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwvid.c @@ -186,9 +186,10 @@ void brcmf_fwvid_detach(struct brcmf_pub *drvr) mutex_lock(&fwvid_list_lock); - drvr->vops = NULL; - list_del(&drvr->bus_if->list); - + if (drvr->vops) { + drvr->vops = NULL; + list_del(&drvr->bus_if->list); + } mutex_unlock(&fwvid_list_lock); } |