aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSameer Wadgaonkar <[email protected]>2017-08-22 13:27:35 -0400
committerGreg Kroah-Hartman <[email protected]>2017-08-22 15:14:55 -0700
commitb74856b4193be752493fa80809abdba508cb3365 (patch)
tree03b9d08d2746a8a678987c7bd98606f7a68186fa
parent51c0f81cca9dbe01c1bada3db62daef839431175 (diff)
staging: unisys: visorbus: Get rid of passthrough function visorchipset_device_destroy
The function visorchipset_device_destroy just called remove_visor_device, we can just combine it with remove_visor_device. Signed-off-by: Sameer Wadgaonkar <[email protected]> Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
-rw-r--r--drivers/staging/unisys/visorbus/visorbus_main.c9
-rw-r--r--drivers/staging/unisys/visorbus/visorbus_private.h2
-rw-r--r--drivers/staging/unisys/visorbus/visorchipset.c2
3 files changed, 4 insertions, 9 deletions
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c
index 1c037a3149ee..38f07b02693a 100644
--- a/drivers/staging/unisys/visorbus/visorbus_main.c
+++ b/drivers/staging/unisys/visorbus/visorbus_main.c
@@ -716,11 +716,12 @@ err_put:
return err;
}
-static void remove_visor_device(struct visor_device *dev)
+void remove_visor_device(struct visor_device *dev)
{
list_del(&dev->list_all);
put_device(&dev->device);
device_unregister(&dev->device);
+ visorbus_response(dev, 0, CONTROLVM_DEVICE_DESTROY);
}
static int get_vbus_header_info(struct visorchannel *chan,
@@ -1119,12 +1120,6 @@ static void remove_all_visor_devices(void)
}
}
-void visorchipset_device_destroy(struct visor_device *dev_info)
-{
- remove_visor_device(dev_info);
- visorbus_response(dev_info, 0, CONTROLVM_DEVICE_DESTROY);
-}
-
/*
* pause_state_change_complete() - the callback function to be called by a
* visorbus function driver when a
diff --git a/drivers/staging/unisys/visorbus/visorbus_private.h b/drivers/staging/unisys/visorbus/visorbus_private.h
index 56c38d558971..8651c8791030 100644
--- a/drivers/staging/unisys/visorbus/visorbus_private.h
+++ b/drivers/staging/unisys/visorbus/visorbus_private.h
@@ -26,7 +26,7 @@
int visorbus_create_instance(struct visor_device *dev);
void visorbus_remove_instance(struct visor_device *bus_info);
int create_visor_device(struct visor_device *dev_info);
-void visorchipset_device_destroy(struct visor_device *dev_info);
+void remove_visor_device(struct visor_device *dev_info);
int visorchipset_device_pause(struct visor_device *dev_info);
int visorchipset_device_resume(struct visor_device *dev_info);
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
index 153c7e5ad79a..25a30a4b46e4 100644
--- a/drivers/staging/unisys/visorbus/visorchipset.c
+++ b/drivers/staging/unisys/visorbus/visorchipset.c
@@ -948,7 +948,7 @@ static int visorbus_device_destroy(struct controlvm_message *inmsg)
}
kfree(dev_info->name);
- visorchipset_device_destroy(dev_info);
+ remove_visor_device(dev_info);
return 0;
err_respond: