diff options
| author | Geert Uytterhoeven <[email protected]> | 2024-02-28 15:00:05 +0100 |
|---|---|---|
| committer | Petr Mladek <[email protected]> | 2024-03-19 16:11:42 +0100 |
| commit | b37cafacbf98ead69c2ecb220fb82b06aee916b9 (patch) | |
| tree | 9b28e2116abdb9092dbb21fa13b1f917b9cbb3b2 | |
| parent | 0381e588949380704005dacdbef6e9a2920260df (diff) | |
ceph: Use no_printk() helper
When printk-indexing is enabled, each printk() invocation emits a
pi_entry structure. This is even true when the call is protected by an
always-false check: while the actual code to print the message is
optimized out by the compiler, the pi_entry structure is still emitted.
Fix this by replacing "if (0) printk(...)" constructs by calls to the
no_printk() helper.
This reduces the size of an arm64 kernel with CONFIG_PRINTK_INDEX=y and
CONFIG_CEPH_FS=y by ca. 4 KiB.
Signed-off-by: Geert Uytterhoeven <[email protected]>
Reviewed-by: Andy Shevchenko <[email protected]>
Reviewed-by: Xiubo Li <[email protected]>
Reviewed-by: Chris Down <[email protected]>
Reviewed-by: Petr Mladek <[email protected]>
Link: https://lore.kernel.org/r/a21767eccb823435a7f18cdf115d7d572b4e945d.1709127473.git.geert+renesas@glider.be
Signed-off-by: Petr Mladek <[email protected]>
| -rw-r--r-- | include/linux/ceph/ceph_debug.h | 18 |
1 files changed, 7 insertions, 11 deletions
diff --git a/include/linux/ceph/ceph_debug.h b/include/linux/ceph/ceph_debug.h index 11a92a946016..5f904591fa5f 100644 --- a/include/linux/ceph/ceph_debug.h +++ b/include/linux/ceph/ceph_debug.h @@ -27,17 +27,13 @@ ##__VA_ARGS__) # else /* faux printk call just to see any compiler warnings. */ -# define dout(fmt, ...) do { \ - if (0) \ - printk(KERN_DEBUG fmt, ##__VA_ARGS__); \ - } while (0) -# define doutc(client, fmt, ...) do { \ - if (0) \ - printk(KERN_DEBUG "[%pU %llu] " fmt, \ - &client->fsid, \ - client->monc.auth->global_id, \ - ##__VA_ARGS__); \ - } while (0) +# define dout(fmt, ...) \ + no_printk(KERN_DEBUG fmt, ##__VA_ARGS__) +# define doutc(client, fmt, ...) \ + no_printk(KERN_DEBUG "[%pU %llu] " fmt, \ + &client->fsid, \ + client->monc.auth->global_id, \ + ##__VA_ARGS__) # endif #else |