diff options
| author | Eric Dumazet <[email protected]> | 2024-09-06 15:44:49 +0000 |
|---|---|---|
| committer | Daniel Borkmann <[email protected]> | 2024-09-11 22:16:04 +0200 |
| commit | b1339be951ad31947ae19bc25cb08769bf255100 (patch) | |
| tree | a51962ccee48aaca6b04e4a6902124b5a97d54a4 | |
| parent | fdfd9d82a43a7a50b9d0989a0440d12a3d68ea15 (diff) | |
sock_map: Add a cond_resched() in sock_hash_free()
Several syzbot soft lockup reports all have in common sock_hash_free()
If a map with a large number of buckets is destroyed, we need to yield
the cpu when needed.
Fixes: 75e68e5bf2c7 ("bpf, sockhash: Synchronize delete from bucket list on map free")
Reported-by: syzbot <[email protected]>
Signed-off-by: Eric Dumazet <[email protected]>
Signed-off-by: Daniel Borkmann <[email protected]>
Acked-by: Martin KaFai Lau <[email protected]>
Acked-by: John Fastabend <[email protected]>
Link: https://lore.kernel.org/bpf/[email protected]
| -rw-r--r-- | net/core/sock_map.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/core/sock_map.c b/net/core/sock_map.c index d3dbb92153f2..724b6856fcc3 100644 --- a/net/core/sock_map.c +++ b/net/core/sock_map.c @@ -1183,6 +1183,7 @@ static void sock_hash_free(struct bpf_map *map) sock_put(elem->sk); sock_hash_free_elem(htab, elem); } + cond_resched(); } /* wait for psock readers accessing its map link */ |