diff options
| author | ChanWoo Lee <[email protected]> | 2023-12-19 17:27:40 +0900 |
|---|---|---|
| committer | Martin K. Petersen <[email protected]> | 2024-01-03 23:05:21 -0500 |
| commit | b08d86e6eb03566c5dc32e6ff10147f80aeb7511 (patch) | |
| tree | 32569cdc3a2afd949f04ec8437546a1e1b19fe56 | |
| parent | ee36710912b2075c417100a8acc642c9c6496501 (diff) | |
scsi: ufs: qcom: Remove unnecessary goto statement from ufs_qcom_config_esi()
There is only one place where goto is used, and it is unnecessary to check
the ret value through 'goto out' because the ret value is already true.
Therefore, remove the goto statement and integrate the '!ret' condition
into the existing code.
Signed-off-by: ChanWoo Lee <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Reviewed-by: Christophe JAILLET <[email protected]>
Reviewed-by: Manivannan Sadhasivam <[email protected]>
Signed-off-by: Martin K. Petersen <[email protected]>
| -rw-r--r-- | drivers/ufs/host/ufs-qcom.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index 9fd8d737edea..0879f5ed4e5b 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -1714,7 +1714,7 @@ static int ufs_qcom_config_esi(struct ufs_hba *hba) ufs_qcom_write_msi_msg); if (ret) { dev_err(hba->dev, "Failed to request Platform MSI %d\n", ret); - goto out; + return ret; } msi_lock_descs(hba->dev); @@ -1748,11 +1748,8 @@ static int ufs_qcom_config_esi(struct ufs_hba *hba) FIELD_PREP(ESI_VEC_MASK, MAX_ESI_VEC - 1), REG_UFS_CFG3); ufshcd_mcq_enable_esi(hba); - } - -out: - if (!ret) host->esi_enabled = true; + } return ret; } |