diff options
| author | Dan Carpenter <[email protected]> | 2024-06-13 21:21:42 +0300 |
|---|---|---|
| committer | Jakub Kicinski <[email protected]> | 2024-06-14 19:08:50 -0700 |
| commit | afc5625e20971e8294a35b2f284a91b0601f9fce (patch) | |
| tree | 8368cc56b3c61691193d26d593b66d5b05cb38c0 | |
| parent | 6a21fb7a9e7af49e4c2fbea71fcadf600798c9f0 (diff) | |
atm: clean up a put_user() calls
Unlike copy_from_user(), put_user() and get_user() return -EFAULT on
error. Use the error code directly instead of setting it.
Signed-off-by: Dan Carpenter <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
| -rw-r--r-- | net/atm/ioctl.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/atm/ioctl.c b/net/atm/ioctl.c index f81f8d56f5c0..0f7a39aeccc8 100644 --- a/net/atm/ioctl.c +++ b/net/atm/ioctl.c @@ -68,7 +68,7 @@ static int do_vcc_ioctl(struct socket *sock, unsigned int cmd, goto done; } error = put_user(sk->sk_sndbuf - sk_wmem_alloc_get(sk), - (int __user *)argp) ? -EFAULT : 0; + (int __user *)argp); goto done; case SIOCINQ: { @@ -83,7 +83,7 @@ static int do_vcc_ioctl(struct socket *sock, unsigned int cmd, skb = skb_peek(&sk->sk_receive_queue); amount = skb ? skb->len : 0; spin_unlock_irq(&sk->sk_receive_queue.lock); - error = put_user(amount, (int __user *)argp) ? -EFAULT : 0; + error = put_user(amount, (int __user *)argp); goto done; } case ATM_SETSC: |