aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorXiaomeng Tong <[email protected]>2022-04-13 13:11:05 +0800
committerPatrik Jakobsson <[email protected]>2022-04-20 09:11:01 +0200
commitac2f033aa4fbc94a512e703a953ed36e1bb45d0a (patch)
treefd67da1d8d5cc9271b4cb80b04c54988fada4d6c
parent4ab85930b7183eaabdaffbcecd89c12e2aca071a (diff)
drm/gma500: fix a potential repeat execution in psb_driver_load
Instead of exiting the loop as expected when an entry is found, the list_for_each_entry() continues until the traversal is complete. To avoid potential executing 'ret = gma_backlight_init(dev);' repeatly, goto outside the loop when found entry by replacing switch/case with if statement. Signed-off-by: Xiaomeng Tong <[email protected]> Signed-off-by: Patrik Jakobsson <[email protected]> [Fixed indentation] Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
-rw-r--r--drivers/gpu/drm/gma500/psb_drv.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c
index 2aff54d505e2..1d8744f3e702 100644
--- a/drivers/gpu/drm/gma500/psb_drv.c
+++ b/drivers/gpu/drm/gma500/psb_drv.c
@@ -396,9 +396,8 @@ static int psb_driver_load(struct drm_device *dev, unsigned long flags)
drm_for_each_connector_iter(connector, &conn_iter) {
gma_encoder = gma_attached_encoder(connector);
- switch (gma_encoder->type) {
- case INTEL_OUTPUT_LVDS:
- case INTEL_OUTPUT_MIPI:
+ if (gma_encoder->type == INTEL_OUTPUT_LVDS ||
+ gma_encoder->type == INTEL_OUTPUT_MIPI) {
ret = gma_backlight_init(dev);
break;
}