diff options
| author | Sebastian Andrzej Siewior <[email protected]> | 2018-05-04 12:42:24 +0200 |
|---|---|---|
| committer | Ingo Molnar <[email protected]> | 2018-05-14 09:12:25 +0200 |
| commit | a59a68fee05d46cccc4279ab6609421f7270398e (patch) | |
| tree | 73f83c0f27b01c785518f53f3e6837f3258bcb8d | |
| parent | 1378447598432513d94ce2c607c412dc4f260f31 (diff) | |
sched/wait: Include <linux/wait.h> in <linux/swait.h>
kbuild bot reported against an intermediate RT patch that the build
fails with:
> In file included from include/linux/completion.h:12:0,
> from include/linux/rcupdate_wait.h:10,
> from kernel/rcu/srcutiny.c:27:
> kernel/rcu/srcutiny.c: In function 'srcu_drive_gp':
> >> include/linux/swait.h:172:7: error: implicit declaration of function '___wait_is_interruptible'; did you mean '__swait_event_interruptible'?
> if (___wait_is_interruptible(state) && __int) { \
That error vanishes a few patches later (in the RT queue) because wait.h
is then pulled in by other means. It does not seem to surface on !RT.
I think that swait should include a header file for a function/macro
(___wait_is_interruptible()) it is using.
Reported-by: kbuild test robot <[email protected]>
Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Cc: Linus Torvalds <[email protected]>
Cc: Mike Galbraith <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: [email protected]
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>
| -rw-r--r-- | include/linux/swait.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/include/linux/swait.h b/include/linux/swait.h index c98aaf677466..84f9745365ff 100644 --- a/include/linux/swait.h +++ b/include/linux/swait.h @@ -5,6 +5,7 @@ #include <linux/list.h> #include <linux/stddef.h> #include <linux/spinlock.h> +#include <linux/wait.h> #include <asm/current.h> /* |