diff options
| author | Ping-Ke Shih <pkshih@realtek.com> | 2021-12-01 17:38:16 +0800 |
|---|---|---|
| committer | Kalle Valo <kvalo@kernel.org> | 2021-12-08 20:31:18 +0200 |
| commit | a58fdb7c843a37d6598204c6513961feefdadc6a (patch) | |
| tree | 333a0bbab801655ab38f7c6b19eb0711de9b47d4 | |
| parent | c2258b29985eac9216a9e55f9d5bead9767f96da (diff) | |
rtw89: don't kick off TX DMA if failed to write skb
This is found by Smatch static checker warning:
drivers/net/wireless/realtek/rtw89/mac80211.c:31 rtw89_ops_tx()
error: uninitialized symbol 'qsel'.
The warning is because 'qsel' isn't filled by rtw89_core_tx_write() due to
failed to write. The way to fix it is to avoid kicking off TX DMA, so add
'return' to the failure case.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20211201093816.13806-1-pkshih@realtek.com
| -rw-r--r-- | drivers/net/wireless/realtek/rtw89/mac80211.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/wireless/realtek/rtw89/mac80211.c b/drivers/net/wireless/realtek/rtw89/mac80211.c index 757685de6b07..a322259f4cc4 100644 --- a/drivers/net/wireless/realtek/rtw89/mac80211.c +++ b/drivers/net/wireless/realtek/rtw89/mac80211.c @@ -27,6 +27,7 @@ static void rtw89_ops_tx(struct ieee80211_hw *hw, if (ret) { rtw89_err(rtwdev, "failed to transmit skb: %d\n", ret); ieee80211_free_txskb(hw, skb); + return; } rtw89_core_tx_kick_off(rtwdev, qsel); } |