diff options
| author | David Gow <[email protected]> | 2023-11-28 15:24:07 +0800 |
|---|---|---|
| committer | Shuah Khan <[email protected]> | 2023-12-18 13:21:14 -0700 |
| commit | a08d4d6284393d44ef4e076288c31d04fc469a58 (patch) | |
| tree | fb4607a130b22be150bf64703cea7221156c5717 | |
| parent | e847934bb124b2ad14bf967d6682e43b0b94c78a (diff) | |
drm/vc4: tests: Use KUNIT_DEFINE_ACTION_WRAPPER
In order to pass functions to kunit_add_action(), they need to be of the
kunit_action_t type. While casting the function pointer can work, it
will break control-flow integrity.
vc4_mock already defines such a wrapper for drm_dev_unregister(), but it
involves less boilerplate to use the new macro, so replace the manual
implementation.
Signed-off-by: David Gow <[email protected]>
Reviewed-by: Maxime Ripard <[email protected]>
Signed-off-by: Shuah Khan <[email protected]>
| -rw-r--r-- | drivers/gpu/drm/vc4/tests/vc4_mock.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/drivers/gpu/drm/vc4/tests/vc4_mock.c b/drivers/gpu/drm/vc4/tests/vc4_mock.c index 63ca46f4cb35..becb3dbaa548 100644 --- a/drivers/gpu/drm/vc4/tests/vc4_mock.c +++ b/drivers/gpu/drm/vc4/tests/vc4_mock.c @@ -153,12 +153,9 @@ static int __build_mock(struct kunit *test, struct drm_device *drm, return 0; } -static void kunit_action_drm_dev_unregister(void *ptr) -{ - struct drm_device *drm = ptr; - - drm_dev_unregister(drm); -} +KUNIT_DEFINE_ACTION_WRAPPER(kunit_action_drm_dev_unregister, + drm_dev_unregister, + struct drm_device *); static struct vc4_dev *__mock_device(struct kunit *test, bool is_vc5) { |