aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVladimir Oltean <[email protected]>2023-02-20 14:23:31 +0200
committerJakub Kicinski <[email protected]>2023-02-21 09:05:01 -0800
commita00da30c052f07d67da56efd6a4f1fc85956c979 (patch)
treee81f7986ec358042dc303b3b9d852cc08d2c7398
parent7ec077744aade63729d58c2d26861c3147a4d8aa (diff)
net: ethtool: fix __ethtool_dev_mm_supported() implementation
The MAC Merge layer is supported when ops->get_mm() returns 0. The implementation was changed during review, and in this process, a bug was introduced. Link: https://lore.kernel.org/netdev/[email protected]/ Fixes: 04692c9020b7 ("net: ethtool: netlink: retrieve stats from multiple sources (eMAC, pMAC)") Signed-off-by: Vladimir Oltean <[email protected]> Reviewed-by: Ferenc Fejes <[email protected]> Link: https://lore.kernel.org/all/[email protected]/ Signed-off-by: Jakub Kicinski <[email protected]>
-rw-r--r--net/ethtool/mm.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ethtool/mm.c b/net/ethtool/mm.c
index e612856eed8c..fce3cc2734f9 100644
--- a/net/ethtool/mm.c
+++ b/net/ethtool/mm.c
@@ -247,5 +247,5 @@ bool __ethtool_dev_mm_supported(struct net_device *dev)
if (ops && ops->get_mm)
ret = ops->get_mm(dev, &state);
- return !!ret;
+ return !ret;
}