diff options
| author | Bert Karwatzki <[email protected]> | 2023-02-02 20:02:36 +0100 |
|---|---|---|
| committer | Alex Deucher <[email protected]> | 2023-02-03 14:21:31 -0500 |
| commit | 9f8b3706eb23bed26f7898af3c6f7fe3858564a1 (patch) | |
| tree | 290cca602a59a186bb7114a022b63d9d691c20ce | |
| parent | a3ee9e0b57f8ecca02d1c16fad4941e09bfe2941 (diff) | |
drm/amdgpu: fix memory leak in amdgpu_cs_sync_rings
amdgpu_sync_get_fence deletes the returned fence from the
syncobj, so the refcount of fence needs to lowered to avoid
a memory leak.
Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2360
Reviewed-by: Alex Deucher <[email protected]>
Tested-by: Mikhail Gavrilov <[email protected]>
Reviewed-by: Christian König <[email protected]>
Signed-off-by: Bert Karwatzki <[email protected]>
Signed-off-by: Alex Deucher <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
| -rw-r--r-- | drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c index 7b5ce00f0602..7af3041ccd0e 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c @@ -1220,10 +1220,13 @@ static int amdgpu_cs_sync_rings(struct amdgpu_cs_parser *p) * next job actually sees the results from the previous one * before we start executing on the same scheduler ring. */ - if (!s_fence || s_fence->sched != sched) + if (!s_fence || s_fence->sched != sched) { + dma_fence_put(fence); continue; + } r = amdgpu_sync_fence(&p->gang_leader->explicit_sync, fence); + dma_fence_put(fence); if (r) return r; } |