diff options
| author | Guillaume Tucker <[email protected]> | 2023-02-09 09:55:36 +0100 |
|---|---|---|
| committer | Shuah Khan <[email protected]> | 2023-02-13 09:09:46 -0700 |
| commit | 9e34fad00fc889abbb99d751a4c22cf2bded10df (patch) | |
| tree | 865e349beff94bb4b375168e70d2e4f36f5352f5 | |
| parent | 1e6b485c922fbedf41d5a9f4e6449c5aeb923a32 (diff) | |
selftests: use printf instead of echo -ne
Rather than trying to guess which implementation of "echo" to run with
support for "-ne" options, use "printf" instead of "echo -ne". It
handles escape characters as a standard feature and it is widespread
among modern shells.
Reported-by: "kernelci.org bot" <[email protected]>
Suggested-by: David Laight <[email protected]>
Fixes: 3297a4df805d ("kselftests: Enable the echo command to print newlines in Makefile")
Fixes: 79c16b1120fe ("selftests: find echo binary to use -ne options")
Signed-off-by: Guillaume Tucker <[email protected]>
Reviewed-by: Guenter Roeck <[email protected]>
Signed-off-by: Shuah Khan <[email protected]>
| -rw-r--r-- | tools/testing/selftests/Makefile | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile index 9619d0f3b2ff..06578963f4f1 100644 --- a/tools/testing/selftests/Makefile +++ b/tools/testing/selftests/Makefile @@ -234,11 +234,10 @@ ifdef INSTALL_PATH @# While building kselftest-list.text skip also non-existent TARGET dirs: @# they could be the result of a build failure and should NOT be @# included in the generated runlist. - ECHO=`which echo`; \ for TARGET in $(TARGETS); do \ BUILD_TARGET=$$BUILD/$$TARGET; \ - [ ! -d $(INSTALL_PATH)/$$TARGET ] && $$ECHO "Skipping non-existent dir: $$TARGET" && continue; \ - $$ECHO -ne "Emit Tests for $$TARGET\n"; \ + [ ! -d $(INSTALL_PATH)/$$TARGET ] && printf "Skipping non-existent dir: $$TARGET\n" && continue; \ + printf "Emit Tests for $$TARGET\n"; \ $(MAKE) -s --no-print-directory OUTPUT=$$BUILD_TARGET COLLECTION=$$TARGET \ -C $$TARGET emit_tests >> $(TEST_LIST); \ done; |