diff options
| author | Aleksandr Burakov <[email protected]> | 2024-03-01 14:15:53 +0300 |
|---|---|---|
| committer | Hans Verkuil <[email protected]> | 2024-04-08 13:48:18 +0200 |
| commit | 9bb1fd7eddcab2d28cfc11eb20f1029154dac718 (patch) | |
| tree | fe07bbecfe155a7ed74fa329deb40794db96c2b0 | |
| parent | 3c2ea5ec1d86d07329e9a117186a0c8cd30d1c40 (diff) | |
media: ngene: Add dvb_ca_en50221_init return value check
The return value of dvb_ca_en50221_init() is not checked here that may
cause undefined behavior in case of nonzero value return.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: 25aee3debe04 ("[media] Rename media/dvb as media/pci")
Signed-off-by: Aleksandr Burakov <[email protected]>
Signed-off-by: Hans Verkuil <[email protected]>
| -rw-r--r-- | drivers/media/pci/ngene/ngene-core.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/media/pci/ngene/ngene-core.c b/drivers/media/pci/ngene/ngene-core.c index 7481f553f959..24ec576dc3bf 100644 --- a/drivers/media/pci/ngene/ngene-core.c +++ b/drivers/media/pci/ngene/ngene-core.c @@ -1488,7 +1488,9 @@ static int init_channel(struct ngene_channel *chan) } if (dev->ci.en && (io & NGENE_IO_TSOUT)) { - dvb_ca_en50221_init(adapter, dev->ci.en, 0, 1); + ret = dvb_ca_en50221_init(adapter, dev->ci.en, 0, 1); + if (ret != 0) + goto err; set_transfer(chan, 1); chan->dev->channel[2].DataFormatFlags = DF_SWAP32; set_transfer(&chan->dev->channel[2], 1); |